-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hub Generated] Publish private branch 'eatkimchee-fist-Microsoft.IoTFirmwareDefense-2023-02-08-preview' #23921
Conversation
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/12395 |
Swagger Validation Report
|
compared tags (via openapi-validator v2.1.1) | new version | base version |
---|---|---|
package-2023-02-08-preview | package-2023-02-08-preview(5075b08) | default(main) |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
~[Staging] ServiceAPIReadinessTest: 17 Errors, 0 Warnings failed [Detail]
Tag package-2023-02-08-preview; Prod region: Deployed
Test run on region: westeurope; Operation coverage: total: 28, untested: 0, failed: 17, passed: 11
Service API Readiness Test failed. Check pipeline artifact for detail report.
Rule | Message |
---|---|
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Workspaces_GenerateUploadUrl |
CLIENT_ERROR |
statusCode: 412, errorCode: HttpResponsePayloadAPISpecValidationFailed, errorMessage: Failed to create HTTP response as per the API specification with one or more errors. Please see details for more information. Consider to retry operation with api-versions ''. Source: runtime OperationId: Firmware_GenerateComponentDetails |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Resource Not Found Source: runtime OperationId: Firmware_GenerateDownloadUrl |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGeneratePasswordHashList |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_GenerateCveSummary |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Resource Not Found Source: runtime OperationId: Firmware_GenerateFilesystemDownloadUrl |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGenerateCveList |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_GenerateCryptoKeySummary |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_GenerateSummary |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_GenerateCryptoCertificateSummary |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGenerateCryptoCertificateList |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_GenerateBinaryHardeningSummary |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGenerateComponentList |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGenerateCryptoKeyList |
CLIENT_ERROR |
statusCode: 400, errorCode: ResourcePostActionFailed, errorMessage: ResourcePostActionFailed: Bad Request Source: runtime OperationId: Firmware_ListGenerateBinaryHardeningList |
CLIENT_ERROR |
statusCode: 412, errorCode: HttpResponsePayloadAPISpecValidationFailed, errorMessage: Failed to create HTTP response as per the API specification with one or more errors. Please see details for more information. Consider to retry operation with api-versions ''. Source: runtime OperationId: Firmware_GenerateBinaryHardeningDetails |
CLIENT_ERROR |
statusCode: 404, errorCode: InvalidResourceType, errorMessage: The resource type 'operations' could not be found in the namespace 'Microsoft.IoTFirmwareDefense' for api version '2023-02-08-preview'. The supported api-versions are '2021-11-10-privatepreview,2022-09-15-privatepreview'. Source: runtime OperationId: Operations_List |
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Hi, @eatkimchee Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @eatkimchee, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi, @eatkimchee, our workflow has detected that there is no management SDK ever released for your RP, to further process SDK onboard for your RP, you should have the SDK client library name of your RP reviewed and approved. Impact: SDK release owner will take the approved management client library name to release SDK. No client library name approval will leads to SDK release delayed. |
Hi, @eatkimchee your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
- remove references to old private preview versions from readme.md - add binary hardening flags to custom-words.txt
Thanks @ihsanali01 , just added minor changes that should fix the validation errors (no swagger changes, just readme and custom words). No idea why the SwaggerAPIView check failed the second time, seems unrelated |
I triggered the APIView job to run again and it passed, but this PR didn't update showing that it passed |
Recorded |
approved @eatkimchee Do you need merge this pr now ? |
Yes @JackTn please merge it so we can begin the SDK release process. Thanks! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@TimLovellSmith @JackTn can you tell why the service api readiness test is failing now when it didn't fail for earlier commits? is this blocking? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@konrad-jamrozik help to tell us this api readiness test failing ? In my opinion this is due to the new api version not release yet. Let me know if i'm wrong. Thanks. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
...on/fist/resource-manager/Microsoft.IoTFirmwareDefense/preview/2023-02-08-preview/common.json
Outdated
Show resolved
Hide resolved
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
Hi @TimLovellSmith , does this have all the changes you requested now? |
I still have this nagging feeling that not marking it as x-ms-secret is going to come back to haunt me... aside from that I don't see any reason to hold this up. |
Sorry for the late reply! I see the failure is in |
Thanks @TimLovellSmith and @konrad-jamrozik. @JackTn whenever you get a chance to merge, it looks like we pass all the necessary checks now. Thanks! |
@msyyc can you help to merge this pr, Thanks |
@eatkimchee Do you want to merge it now? |
@msyyc Yes please merge it now, thanks! |
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
May 31, 2023
May 31, 2023
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.